Skip to content

🟢 Add tests for All and Auto discovery list resolution (aws, azure, gcp)#6994

Merged
preslavgerchev merged 4 commits intomainfrom
test/discovery-resolved-resources
Mar 20, 2026
Merged

🟢 Add tests for All and Auto discovery list resolution (aws, azure, gcp)#6994
preslavgerchev merged 4 commits intomainfrom
test/discovery-resolved-resources

Conversation

@preslavgerchev
Copy link
Copy Markdown
Contributor

No description provided.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Copy link
Copy Markdown

@mondoo-code-review mondoo-code-review bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

New snapshot tests ensure discovery list constants stay in sync across AWS, Azure, and GCP providers.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Mar 19, 2026

Test Results

5 565 tests  +18   5 561 ✅ +18   2m 3s ⏱️ ±0s
  412 suites ± 0       4 💤 ± 0 
   31 files   ± 0       0 ❌ ± 0 

Results for commit 2eeacd4. ± Comparison against base commit 6d9b66c.

♻️ This comment has been updated with latest results.

preslavgerchev and others added 2 commits March 19, 2026 21:01
…riven (aws, azure, gcp)

All now includes every discovery target (Auto + extras). Rewrote
azure/gcp TestGetDiscoveryTargets as table-driven tests for consistency.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Copy link
Copy Markdown

@mondoo-code-review mondoo-code-review bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Discovery list resolution is consolidated and better tested; no behavioral changes.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@preslavgerchev preslavgerchev merged commit 8fdc049 into main Mar 20, 2026
22 checks passed
@preslavgerchev preslavgerchev deleted the test/discovery-resolved-resources branch March 20, 2026 12:38
@github-actions github-actions bot locked and limited conversation to collaborators Mar 20, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant